Skip to content

Leetcode solution 11 to 16 added #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2024
Merged

Leetcode solution 11 to 16 added #342

merged 3 commits into from
Jun 1, 2024

Conversation

Yashgabani845
Copy link
Contributor

@Yashgabani845 Yashgabani845 commented Jun 1, 2024

Related Issue

Closes #325

Description

i have added solution fo 6 leetcode problem
each of them contain at least thses sections

  1. problem statement
  2. problem description
  3. example
  4. code in all of 3 languages
  5. time and space complexity analysis
  6. conclusion

Type of PR

  • Feature enhancement
  • Documentation update

Screenshots / Videos (if applicable)

Screenshot (297)
Screenshot (298)
Screenshot (295)
Screenshot (296)

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

i know these are not as i said in issue but at that moment
i did not thought this will take much time
so i have added work which was possible atm
you can label PR whatever this many contribution deserve

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 3:41pm

Copy link
Contributor

deepsource-io bot commented Jun 1, 2024

Here's the code health analysis summary for commits 4e295ef..967efb0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Yashgabani845
Copy link
Contributor Author

@ajay-dhangar please review this PR

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels Jun 1, 2024
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only remove one line in 0011-Container-with-most-water.md in botton text is

```

The two-pointer approach is efficient for solving the Container With Most Water problem, allowing us to explore all possible containers by adjusting the pointers based on the heights of the lines, ensuring that we find the container with the maximum possible area.


```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 166 to 168

```

@ajay-dhangar
Copy link
Member

Most importantly, you should focus on one problem at a time rather than covering multiple issues simultaneously. This way, I can assign you Level 3 tasks for individual DSA problem-solving documentation. By doing so, you can concentrate on the quality of the content rather than the quantity or the number of solutions.

Copy link

sonarqubecloud bot commented Jun 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Yashgabani845
Copy link
Contributor Author

Yashgabani845 commented Jun 1, 2024

@ajay-dhangar i have changed as you said
and yes now further i will work only on one issue at a time
generally i raise new issue after making PR of previous one but then i saw people raising multiple issues
anyway thanks for giving feedback i will work accordin to it

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit c9eaad7 into codeharborhub:main Jun 1, 2024
8 checks passed
@sanjay-kv sanjay-kv added level1 GirlScript Summer of Code | Contributor's Levels and removed level2 GirlScript Summer of Code | Contributor's Levels labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level1 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: dsa leetcode solution
3 participants